Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): remove unused 'selected' field from OllamaManager defaults #230

Merged
merged 1 commit into from
Nov 11, 2024
Merged

fix(api): remove unused 'selected' field from OllamaManager defaults #230

merged 1 commit into from
Nov 11, 2024

Conversation

psyray
Copy link
Contributor

@psyray psyray commented Nov 10, 2024 •
edited
Loading

Fixes #231

Summary by Sourcery

Bug Fixes:

  • Remove the 'selected' field from the defaults dictionary in the OllamaManager class to prevent a 500 error during LLM selection.

@psyray
fix(api): remove unused 'selected' field from OllamaManager defaults
3828463 
- Removed the 'selected' field from the defaults dictionary in the OllamaManager class within the API views, as it is no longer needed and cause 500 error on LLM selection
@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented Nov 10, 2024 •
edited
Loading

Reviewer's Guide by Sourcery

This PR removes an unused 'selected' field from the OllamaManager defaults dictionary in the API views. The field was causing 500 errors during LLM selection and is no longer needed for the functionality.

Class diagram for OllamaManager defaults update

classDiagram
    class OllamaManager {
        - selected_model: String
        - use_ollama: Boolean
        - selected: Boolean
    }

    note for OllamaManager "The 'selected' field has been removed from the defaults dictionary."
Loading

File-Level Changes

Change Details Files
Remove unused field from OllamaManager defaults
  • Removed the 'selected: True' field from the defaults dictionary in the put method
  • Simplified the model selection logic by removing redundant field
 web/api/views.py
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@psyray psyray self-assigned this Nov 10, 2024
sourcery-ai[bot]
sourcery-ai bot reviewed Nov 10, 2024
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @psyray - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@psyray psyray linked an issue Nov 10, 2024 that may be closed by this pull request
bug(api): 500 error on LLM selection #231
Closed
3 tasks
@psyray psyray added the bug Something isn't working label Nov 10, 2024
@AnonymousWP AnonymousWP merged commit 660ad44 into release/2.1.1 Nov 11, 2024
5 checks passed
@AnonymousWP AnonymousWP deleted the fix-llm-selection branch November 11, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@AnonymousWP AnonymousWP AnonymousWP approved these changes

@0b3ud 0b3ud Awaiting requested review from 0b3ud

Assignees

@psyray psyray

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(api): 500 error on LLM selection
2 participants
@psyray @AnonymousWP